esy-issues icon indicating copy to clipboard operation
esy-issues copied to clipboard

What happens when we're pointing to a git branch that's been force pushed?

Open chenglou opened this issue 8 years ago • 5 comments

I think I've encountered some problems around this. I've force pushed to a few repos. The install hung forever. Sorry for being vague, can't get a good repro right now. Feel free to close if there's no such problem!

chenglou avatar Feb 07 '17 22:02 chenglou

(See discord conversation) things are fixed after an npm cache clean. The repro is

  "dependencies": {
    "reason": "facebook/reason#esy",
    "ocaml": "esy-ocaml/ocaml#esy"
  },
  "peerDependencies": {
    "reason": "facebook/reason#esy",
    "ocaml": "esy-ocaml/ocaml#esy"
  }

The stuck download comes from pnpm. This happens even if someone hasn't used pnpm/esy directly before.

chenglou avatar Feb 07 '17 23:02 chenglou

Oh it has to do with force pushing!? I would hope pnpm would check the actual commit hash before using something from the cache. cc @andreypopp

jordwalke avatar Feb 08 '17 05:02 jordwalke

I'd expect it to work... probably it reuses shrinkwrap'ed resolution? Did you try to remove shrinkwrap.yaml before trying to run esy install?

andreypopp avatar Feb 08 '17 08:02 andreypopp

Not sure sorry. Can't repro this anymore but people definitely reproed on other laptops.

chenglou avatar Feb 08 '17 08:02 chenglou

will try to remove shrinkwrap next time it happens.

jordwalke avatar Feb 08 '17 09:02 jordwalke