Jordan Schalm
Jordan Schalm
Fixed (but still a bit buggy). Server will respond with a 415 if a filename isn't valid ASCII but client will still think the file uploaded properly and behave strangely...
> can we address [this edge case](https://github.com/onflow/flow-go/blob/b4a7dbb4a6b7cf09a481f7eaa49c5bd8057f2427/engine/collection/compliance/core.go#L304-L313)? There might be a non-trivial spamming opportunity here depending on the value of SkipNewProposalsThreshold Could you explain how this relates to a spamming...
> if the blocks are cache, the attacker floods our cache with garbage, effectively rendering it useless Thank you for the explanation. Initially I thought this was no different than...
> suggestion Use terminology: "header validation" and "payload validation" This suggestion is not much more accurate, IMO. It's true that "HotStuff validation" is _limited_ to the header, but it does...
I think the failing consensus tests here would be fixed by the addition of a block message queue to `VoteAggregator` in https://github.com/onflow/flow-go/pull/3277
bors merge
bors merge