flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

Update HotStuff Reader CLI Tool

Open jordanschalm opened this issue 2 years ago • 1 comments

This PR modifies the HotStuff CLI command, replacing get-view with get-liveness and get-safety.

Example usage on Localnet:

Screen Shot 2022-10-10 at 12 36 57 PM Screen Shot 2022-10-10 at 12 29 46 PM Screen Shot 2022-10-10 at 12 28 36 PM

jordanschalm avatar Oct 10 '22 10:10 jordanschalm

Codecov Report

Merging #3363 (dfd7c73) into feature/active-pacemaker (6ca919a) will decrease coverage by 0.02%. The diff coverage is n/a.

@@                     Coverage Diff                      @@
##           feature/active-pacemaker    #3363      +/-   ##
============================================================
- Coverage                     55.30%   55.28%   -0.03%     
============================================================
  Files                           748      748              
  Lines                         69412    69412              
============================================================
- Hits                          38387    38372      -15     
- Misses                        27890    27901      +11     
- Partials                       3135     3139       +4     
Flag Coverage Δ
unittests 55.28% <ø> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
network/p2p/dns/resolver.go 91.51% <0.00%> (-4.85%) :arrow_down:
...s/hotstuff/votecollector/staking_vote_processor.go 81.05% <0.00%> (-3.16%) :arrow_down:
admin/command_runner.go 79.88% <0.00%> (-1.12%) :arrow_down:
fvm/environment/contract_updater.go 66.54% <0.00%> (-0.72%) :arrow_down:
engine/access/ingestion/engine.go 59.62% <0.00%> (-0.56%) :arrow_down:
...sus/hotstuff/timeoutcollector/timeout_processor.go 86.18% <0.00%> (+1.97%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 10 '22 10:10 codecov-commenter

bors merge

jordanschalm avatar Oct 18 '22 13:10 jordanschalm

Build failed:

bors[bot] avatar Oct 18 '22 13:10 bors[bot]

I think the failing consensus tests here would be fixed by the addition of a block message queue to VoteAggregator in https://github.com/onflow/flow-go/pull/3277

jordanschalm avatar Oct 18 '22 16:10 jordanschalm