Jo Potts

Results 10 comments of Jo Potts

Jacob, please add an `IN` option! If there's just one thing in the next release, then let this be it. Awesome software. Thank you!

Sorry. Last thing (I think). Just added another commit to the pull request - the last commit. It's to be able to change the default result of the able calls.

Hi John, Thanks for the comments on the last pull request. I agreed with them all and thanks for taking the time to look into it in detail. I fixed...

Hi. Were you waiting for me to do anything else with this? No rush. Just wondering. Cheers.

No worries about the questions. Best to get it right. You're right about the goals: Sending options (to class and instance methods of able_by? methods), and setting a default. The...

Just a quick reminder in case I catch you with a moment to spare! I'm using this on a couple of sites, so it would be great to get it...

Hi John. Have you had a chance to look at this again yet?

Looks like an improvement. You're welcome to add the PR here too: https://github.com/fast-jsonapi/fast_jsonapi/issues/1

@shishirmk Thanks for the great work you've put into this gem. It would be great to see some PRs getting merged. Can Netflix spare any additional resource? Or perhaps an...

I've fixed the comments and moved some inflections, added a couple more tests, and got the translator to check the tests and all look ok. I'm sure it's not perfect,...