Jose Perez Rodriguez

Results 158 comments of Jose Perez Rodriguez

I'm taking a look at this by trying to analyze the dump so I can get which test is causing this.

@jformacek thank you so much for sending out the fix! Would you mind also adding a unit test in: https://github.com/dotnet/runtime/blob/39d82c99b44db470f43fc12498c1aec082e5c6e2/src/libraries/System.DirectoryServices.Protocols/tests/DirectoryServicesProtocolsTests.cs#L15 that uses a timeout and perhaps that validates that the...

I think the test you pointed out above is good enough. Ideally we want to make sure that the server is timing out, but the fact that the native method...

It would of course be good to have this test you had before be a theory though, and take different inputs to make sure we have the right behavior, for...

Well, `SearchRequest.TimeLimit` public API is a `TimeSpan` right? and that is the same for Linux and Windows, so it might be good to add a test with `searchRequest.TimeLimit = new...

It won’t. This change was merged into .NET 7, so it will be present in .NET 7 but there are no current plans to backport this to .NET 6.

the dash (`-`) is mostly a normal character in Regex except when used in character classes. If the dash is not either the first or the last character inside your...

Note that the pattern you shared above doesn't need the dash to be escaped (since the dash is at the end of the character class). You should get the same...

It wasn't, thanks for pointing it out. I have closed both issues now.