Jon Waldstein comments

Results 41 comments of


Jon Waldstein

Enhancement: Improvements to recurrence in the Donation and Subscription models

@JasonTheAdams I haven't tested anything yet but this is looking great, nice job! Re: `initialDonationId` yes let's get rid of that from the donation model. It's very much an underlying...

Fix: fee recovery in the “donation summary” with wrong value

@ravinderk can you please update the PR description to describe the additional changes you made? I see a lot of things were removed and replaced and it's a little hard...

Add JSON-LD schema markup to donation receipt

@JasonTheAdams @mathetos did you ever come to a conclusion on this?

fix: prevent payment failure when multi level donations are too long on recurring stripe

@Benunc was this issue ever reported again? it seems like a fairly simple fix for us to include in core to limit the characters of the subscription name.

Sites without Donation Confirmation page configured should not prevent Stripe donations.

@Benunc I am confirming this is still an issue (at least on legacy forms). We should really fix this with your suggestions.

Feature: add givewp_db_pre_query hook

@JasonTheAdams this is ready for review. As we discussed, i'd like to put this to the test in different real-world situations before introducing a more permanent GiveWP setting.

Fix currency preview field not accurately displaying preview on page load

I can confirm this has not been resolved yet.

Add filters or more actions to receipt shortcode template

@Jany-M what specific customizations are you looking to achieve? We do currently have the `give_donation_receipt_args` filter and those before/after actions. Although, it sounds like you're looking to go further than...

Add filters or more actions to receipt shortcode template

@Jany-M I agree, a lot of what your describing we refer to as the _legacy_ codebase. The receipt snippet above dates back to 2014-2016 - a lot has happened since...

Fatal Error: Declaration of Illuminate\Http\Request::get must be compatible with Symfony\Component\HttpFoundation\Request::get

@robrecord unfortunately we can't upgrade that package because we have to support php 5.6 at the moment. I'll discuss with the team to see if there's anything we can do...