Jon Harmon

As a factory user, I'd like the generated function to have srcref, so that I can keep comments.

If they have styler installed, we could style the return to make it easier to edit.

Use the vignette from #5 as a model for an rstudio addin.

package_coverage() vs minimal package (on Windows?)

2

In today's workshop, I made the minimal package available [here](https://github.com/jonthegeek/workshoppractice). When I check coverage, I get this error: ``` [main 15:40:52] > devtools:::test_coverage() ℹ Computing test coverage for workshoppractice Error...

Icon warnings in chapter 2

1

The second code block in [2.2.5 Limited choices](https://mastering-shiny.org/basic-ui.html#limited-choices) throws warnings: ``` #> This Font Awesome icon ('angry') does not exist: #> * if providing a custom `html_dependency` these `name` checks...

Update all "master" branch references to "main"

1

I confirmed that all repos references now use "main" instead of "master". Importantly, the missing "main" in the GHA means the other master --> main changes haven't been deployed to...

According to the [docs](https://github.com/rstudio/plumber/blob/56a69494cf15c3c3ca0831a86a91ba033337206a/R/session-cookie.R#L36), the `path` argument "Defaults to the request URI." As far as I can find, though, it defaults to unset. I don't (yet) have an example of...

`xml_attr(x, "href")` returns un-encoded URLs if that's how they appear in the source, but then those URLs fail in `url_absolute`. ``` r url [1] NA xml2::url_absolute( utils::URLencode(url), base = "https://example.com/"...

I assign the copyright of this contribution to Hadley Wickham.

Importing Functions

1

I'd love to see advice on when to import (vs use_standalone?) vs write your own, and any related advice around them. For example, [*Clean Code*](https://www.amazon.com/Clean-Code-Handbook-Software-Craftsmanship-ebook/dp/B001GSTOAM) recommends always wrapping imported functions...