Jon Harmon

Update this issue with known things that have to happen before we feel ready for CRAN.

If I refer to a function via a variable, the `class` column of `s3_methods_generic` isn't what I'd expect. ``` this_func Warning in .S3methods(generic.function, class, envir): generic function #> 'this_func' dispatches...

dataset_subset hides dataset subclass

2

I expected `dataset_subset` to keep dataset properties, but it hides them. Could we either sort out a way to elevate the dataset to the "top" of that object, or at...

docker build guide doesn't work

6

I'm trying to build a torch-friendly environment in docker using `docker/build_env_guide.md`, but I'm hitting errors. I'll specify them below, but it looks like the guide was updated (it mentions `cuda-113`...

I saw one of these while reading a help doc so I figured I might as well find-and-replace them all.

Update Status in Welcome?

2

From the [Welcome](https://design.tidyverse.org/index.html): > This book will be under heavy development for quite some time; currently we are loosely aiming for completion in 2020. You’ll find many chapters contain disjointed...

As a factory maker, I'd like to provide the function in lambda notation, so that I can more quickly build functions. rlang::as_function should make this relatively straightforward to implement, I...

Stateful functions

4

This package completely kills the "stateful functions" use case of function factories. It wouldn't be hard to fix that, but I should give it some thought. Two things: * Probably...

Environments as Variables

1

``` library(factory) # Define the function the normal way. get_x

Function Chooser

1

As a factory author, I'd like to author factories where I choose a different function based on an input, so that I can write a different style of factory. I...