Jon Rohan

Results 33 issues of Jon Rohan

Part of https://github.com/github/primer/issues/3785 ### Changelog #### Changed Refactoring `Text` to use CSS modules behind the primer_react_css_modules_team feature flag. #### Removed ### Rollout strategy - [ ] Patch release - [x]...

staff

Closes https://github.com/github/primer/issues/4251 ### Changelog #### New #### Changed #### Removed ### Rollout strategy - [ ] Patch release - [ ] Minor release - [ ] Major release; if selected,...

skip changeset
integration-tests: recommended
staff

This adds a `defaultAs` argument to the `toggleStyledComponent` utility. This is because we were defaulting the `BaseComponent` to `'div'` when no `as` prop was provided. This was incorrect sometimes because...

skip changeset
integration-tests: recommended
staff

Closes https://github.com/github/primer/issues/4032 ### Changelog #### New Convert Breadcrumbs to css module behind feature flag ### Rollout strategy - [ ] Patch release - [x] Minor release - [ ] Major...

integration-tests: recommended
staff

### Changelog #### Changed Remove the CSS modules feature flag from the Link component ### Rollout strategy - [ ] Patch release - [x] Minor release - [ ] Major...

integration-tests: recommended
staff

### Changelog #### Changed Move CounterLabel css modules feature flag to staff ### Rollout strategy - [x] Patch release - [ ] Minor release - [ ] Major release; if...

integration-tests: recommended
staff

### Changelog #### Changed Move Checkbox css module feature flag to staff ### Rollout strategy - [x] Patch release - [ ] Minor release - [ ] Major release; if...

integration-tests: recommended
staff

### Changelog #### Changed Move ButtonGroup css module feature flag to staff ### Rollout strategy - [x] Patch release - [ ] Minor release - [ ] Major release; if...

integration-tests: recommended
staff

This removes the CSS modules feature flag from the `Label` component that was first introduced 4 weeks ago https://github.com/primer/react/pull/4893 ### Changelog #### Changed Label is styled by CSS modules. ###...

integration-tests: recommended
staff

This removes the CSS modules feature flag from the `Text` component that was first introduced 2 months ago https://github.com/primer/react/pull/4874 ### Changelog #### Changed Text is styled by CSS modules. ###...

integration-tests: recommended
staff