Jon Rohan

Results 42 comments of Jon Rohan

> use something like grunt-newer-explicit to watch the pertinent ActionScript source files (+ "package.json", which will still yield many false positives) to prevent unnecessary building of the SWF. I'm down...

I don't know much about actionscript optimization techniques, but this is a good excuse to read up. :+1:

Here's what github does to enable copy to clipboard without flash. It's based on useragent sniffing and not feature detection, which is why it's not in ZC yet. https://gist.github.com/jonrohan/81085b119d16cdd7868a

The only thing that worries me about this is the focusing. I did try and see if I could un-focus the flash object. and ran into problems that browsers won't...

I'm for this idea, but in general I dislike catches without doing anything. I would like us to catch them more (Actionscript/JavaScript) and pass a more useful error to the...

I def!!! want some kinda flash tests going on. The tests from the javascript side, i have to fake the flash side (which I'm ok with leaving that way). But...

That would be awesome! But I haven't the slightest idea about Vim theming. Would greatly accept any PR and host the theme repository.

Wow, nice job. Would like to look into this more though and create a `vim.js` adapter in the compiler for this.

I'm going to hold on this one until we can get a single release, with only this change, `ButtonComponent` is currently our most used with `OcticonComponent` closely behind. Because of...

👋🏻 I'm closing this in favor of https://github.com/primer/view_components/pull/1325 The reason is, we want to use the Beta namespace for the Button update and instead deprecate the old component