Jon Koops
Jon Koops
I think the idea was to remove the base theme altogether no?
Yes, that seems a good first step.
I am a big supporter of using Rolldown, it is much faster! Couple of notes though: - I am seeing some validation errors when running the build. - Assets are...
@IvanSanchez would love to give this an in-depth review, but I am a bit tied up for the next alpha. Seems like a nice addition though!
@Falke-Design looks like this one might already be closed? I see the related PR was merged, but never linked to this issue.
@Falke-Design looking at the [`orientation`](https://developer.mozilla.org/en-US/docs/Web/API/Window/orientation) property, it is indeed deprecated, however, it is fully supported in only 'mobile' browsers, which make it very reliable for detecting them. The API that...
Starting to think we should be splitting out OSM specific logic out of `TileLayer` and into a dedicated `OSMTileLayer` since more logic for a specific provider is being added to...
> If we had four different tile providers with four different hacks for each one, I'd be in favour of refactoring; but with only OSM I'd leave it be. That...
I am not against landing this in Leaflet per-se, especially if it will be a future requirement for using OSM on the web. Do note that Leaflet has a long...
Got it (sorry I skimmed over the comments above too fast), in that case, this all LGTM logic wise. If you could address the review comment I had about code...