Jon Koops

Results 690 comments of Jon Koops

Totally agree, I am of the personal opinion that we need to get back to simple packages that are aligned across the ecosystem, just wanted to throw out the option....

Looks like at least 22.x is getting a backport (see https://github.com/nodejs/node/issues/52697), and I was under the impression that the same would be done for 20.x and even 18.x but I...

So at the very least 20.x will have a backport (https://github.com/nodejs/node/issues/52697#issuecomment-2489576959). Might be worth a semver major once 18.x reaches EOL.

> does this mean that when using the js admin-client when an error occurs it will log them in the keycloak server logs? No, this is about errors from the...

@keycloak/ui it seems that these changes fail some of the tests, likely because the notifications being checked now have a different text associated with them. I unfortunately don't have time...

Assigning this to @edewit as he has volunteered to fix this one up :1st_place_medal:

> If you think there is a chance to backport a light-weight version, please do if your time permits. I discussed this with @edewit as well, and we're quite sure...

Yes, for sure. I originally set the impact for this bug as low, but I'd honestly consider it more like high impact considering the implications for debugging for users and...

Hmmm, yeah. Looks like I'll have to port those over first. I wanted to clean up that code anyways so I will open up some PRs to do so.

Converting this to a draft until I have all the aforementioned issues resolved.