Jonathan Pelham
Jonathan Pelham
> i'm not familiar with networkx (and a little surprised it has such a similar api!), but this seems like a nice addition! A few asks, and feel free to...
Here's a screenshot. I saved my code as alt_model_graph.py and you can see where I import it. The model is just a draft I was messing around with .
Sorry just realised you meant the code in the docstring. Wait one
Ok that throws an error I will fix and update the pull request.
Interestingly I fixed that and found a bug that I didn't understand. In that example there is a self loop obs -> obs However when iterating over the same data...
OK I tested my fix and attributes aern't preserved for subgraphs correctly as i'm using compose to combine subgraphs and it overwrites attributes by default. https://networkx.org/documentation/stable/reference/algorithms/generated/networkx.algorithms.operators.binary.compose.html?highlight=compose I've got to put...
Right i've sorted out the attribute behaviour. networkx doesn't have a way to add attributes to a subgraph you either make them graph, node, or edge attributes. I've made them...
ok pre-commit has run successfully and i've committed those changes. I'll have a think re tests
Right i've added a simple test in to test_model_graph.py. I think i've understood how that test function file works correctly. I extended SeededTest as used for the modelgraph tests but...
I think i've solved all the linting issues now