Jonas Hübotter
Jonas Hübotter
Really like these ideas. I just think that using a tree with a method `enabled?` like I proposed in #38 would be even nicer as it allows for two separate...
But as I said, I think we should think separately about storing/retrieving the data (using `jsonb`, `json` or whatever) and structuring it to make it easy to fetch (when testing...
I don't know if I just got this wrong, but this problem could be resolved, temporarily, by providing a configuration option `hash_serializer` that defaults to `Hash`. Right?
Hey, I'm sorry for getting to you this late. Unfortunately, I don't think I'll be able to debug this in the near future. It does look kind of odd. Feel...
Hmm... have you tried with Rails 6? I'm thinking maybe it's a Rails issue because the tests are using Rails 6.
What default categories have you configured for `NotificationSettings`?
Does it work if you pass symbols to the categories option, as in `:notification`?
That seems weird to me cause this area of the code is well-tested 🤔 Can you confirm that your configuration looks somewhat like https://github.com/jonhue/notifications-rails/blob/master/notification-settings/spec/support/rails_app/config/initializers/notification_settings.rb#L5 ?
I don't think I'll have the capacity to work on this in the near future, but I'm happy to review pull requests 🙂
Unfortunately, I don't think that I'll have time to look into this in the next couple of weeks. I'm always happy to review pull requests though 🙂.