Jon Gjengset
Jon Gjengset
Yes, this seems like a useful addition! It'd be useful to see before/after though.
Isn't the line shown before you start scrolling currently, or am I misremembering?
Ah, good catch! Would you mind including a test case for this too so we make sure this doesn't regress in the future?
That's an interesting idea! I think you could implement this as a feature of the "zoom" functionality. Basically, when you zoom into an element, walk all the stack frames above...
Exactly! How about: > xxx samples, x% overall, x% of current stack
Yeah, I think you may have to walk up the elements dynamically, which isn't great, but may be necessary. We'll need a somewhat efficient way to do it though. And...
Can you give an example of what it looked like and what filtering you'd like to see?
@benbrittain Hmm, I get a 404 for that link? I wonder if you couldn't get quite far by using the [new `--skip-after` flag](https://github.com/jonhoo/inferno/pull/224) to filter out the prefix of each...
Woah, yeah, that's certainly a right mess! This doesn't seem like something `skip-after` can fix, but it's also not clear that the flamegraph here is _wrong_. The reason for the...
This looks great, though it appears that it doesn't fully compile?