Jon Gallant

Results 233 comments of Jon Gallant

Is this secret that needs to be removed? https://github.com/Azure/aca-landing-zone-accelerator/blob/main/scenarios/aca-internal/bicep/main.parameters.json#L42

Shouldn't this be env var driven? https://github.com/Azure/aca-landing-zone-accelerator/blob/main/scenarios/aca-internal/bicep/main.parameters.json#L72

There are many bicep modules in this repo, that could potentially be adopted to the form of and moved over to our bicep core - or the public bicep registry.

@greenie-msft - I see OPENAI_API_KEY in the readme, but I don't see it in bicep. https://github.com/Azure-Samples/function-csharp-ai-openai-chatgpt Could you look into using `azd env set OPENAI_API_KEY value`, and then, read that...

Please add a devcontainer to the project. You can find examples to use in our official templates. Thanks

More suggestions: Steal the code in this readme to display the buttons. Add text to readme on how to open in codespaces... https://github.com/Azure-Samples/openai-plugin-fastapi

I got this: ERROR: deployment failed: failing invoking action 'provision', error deploying infrastructure: deploying to subscription: Deployment Error Details: AccountNameInvalid: stjongfilemanager1storage is not a valid storage account name. Storage account...

This is how we do it: name: !empty(storageAccountName) ? storageAccountName : '${abbrs.storageStorageAccounts}${resourceToken}' Just the prefix and the token.

I really created that extension to solve the codespaces issues and haven't tested it on WSL. Are you sure this extension will solve your problem?