Jon Calhoun

Results 39 comments of Jon Calhoun

more testing.

Okay I figured out what is happening. Here is how to reproduce and more info. You can tell me if this is intended behavior, but it was driving me insane...

That gif repeating might make it slightly annoying to follow.. 😦

@natdm Did this ever get fixed? Was going to reenable the plugin soon if so 😄 If not, can I help at all?

Looks like github trimmed the gif a bit 😦 Here's the full one - https://www.dropbox.com/s/36yhdrzte0vj22p/links-markdown.gif?dl=0

All of these proposals are looking for a way to return the error as a specific type, which I agree is nice if possible, but have there been any discussions...

> This would break the following: > > ``` > var _ = errors.As > ``` Darn, you are right. I missed that case. Kinda sucks though, because the change...

> I believe this was intentional in [9dd6af1](https://github.com/gorilla/csrf/commit/9dd6af1f6d30fc79fb0d972394deebdabad6b5eb), because there is no reliable way to tell if a request came in over HTTPS or HTTP, it assumes it's HTTPS to...