Jonathan Binney

Results 121 comments of Jonathan Binney

Released into foxy; rosdistro PR is here: https://github.com/ros/rosdistro/pull/36518 Looks like foxy hits end-of-life in may; you might want to update to humble. I went ahead and also made new releases...

Not sure how index.ros.org works, but that page says it was last updated in december, so I doubt it would have it? It looks like laser filters built for foxy:...

@peci1 i think this is about moving to the ros-control org, not the ros_control repo. @davetcoleman is that right?

This seems reasonable to me. @shr-project could you rebaseon top of the current ros2 branch? I've fixed the tests now so we can make sure they pass for this PR.

@shr-project looks like the linter prefers explicitly sized types, could you switch to that? Here is the error from the linter: ``` /tmp/ws/src/filters/include/filters/filter_base.hpp:219: Use int16/int64/etc, rather than the C type...

@Oyssster hard to tell. I'd suggest catching this in gdb and poking at the fields and addresses of `msg` and `cloud_in_scan_` not see if anything looks suspicious. It looks like...

Seems like a reasonable feature to add but I'm short on time - could you submit a PR that adds it? To do this you'd need to: - read a...

Yes - I've got a couple PRs I want to merge first, then I'll release. I've created a noetic-devel branch so that I could merge the header path changes in...

Melodic release here: https://github.com/ros/rosdistro/pull/31119 I've updated the source and doc branches to match the branch that is actually released into melodic: kinetic-devel. After that PR gets merged I'll do the...