Jonathan Binney

Let me try to reproduce this - I've got a similar setup

This doesn't happen on 22.04 on humble; I'm guessing a recent commit added something that doesn't work with the older cmake version. Could you try a previous commit of filters...

It looks like interface libraries with sources was added in 3.19. CI for humble runs on 22.04, so I missed this problem. The interface library was added in https://github.com/ros/filters/pull/70 @wep21...

Ubuntu 20.04 is only "recommended" to support for humble packages, but since filters is pretty core I think we should support it. Here are the cmake versions for each platform...

Wow, this is cool! Thanks @jcarlosgm30 for implementing it! This seems like a good change, but since it is a big change it'll take some time to understand, review and...

When I initially read the title of this PR, I thought it was turning each individual filter into a ros2 component.... but now I see that it is much simpler...

> The component has to be compiled as a shared library, and we want to keep backward compatibility by having an executable node for each filter chain. Yes we want...

Adding new functionality and doing code reorganization in one commit also violates many of the best practices of software development :-) Could you undo the renaming of the nodes and...

@clalancette thank you for doing this! It looks like this PR removes the usage of `python_cmake_module` but doesn't add `find_package(Python3)`. Is that because that is handled by `find_package(ament_cmake_pytest REQUIRED)`?

@clalancette that sounds good to me and this seems mergeable, but I realized this isn't actually one of the packages I maintain so @mabelzhang should make the call on merging.