Jonathan Binney

Thanks for taking a look @bjsowa ! I've got some time to review this PR this week. It looks like tests are failing on some EOL ROS2 distros, so i've...

@berend-kupers could you rebase onto current head? Then the tests will run on the updated list of distros. Thanks!

(or merge ros2 branch into this one, whichever you prefer)

Looks like the speckle filter test is failing on CI, and I have the same issue when I run locally. It looks like an error during rclcpp shutdown - do...

I've been looking into what changes would be needed to the filters library to avoid needing to create extra nodes. I think a few things: Add protected member function to...

Still some tests failing - i should have time to debug them later this week to see what is going on.

ok i think i know why the tests are failing intermittently. In `test_speckle_filter.test.py` the subscribers are created, then the publishers, then the raw laser scan is published, then we wait...

By "transient local" do you mean make it a local variable? I'm not sure how that would fix this. I like the idea of publishing the scan at a fixed...

> I meant setting the quality of service setting durability to "transient local" for the publisher. Then the publisher should persist samples for "late-joining" subscribers. Ah, perfect! I'm not familiar...

Interesting - a couple tests still failing but I'm having a harder time reproducing it locally. Debugging now.....