Jon Billings

ooh, should this have been a PR against the 202207-fixes branch instead?

Problem description in #897

It certainly fixed the problem of the duplicate and very early signal. I think you're right that 114 would be more correct. I'll update to that. Most of the comment...

I believe @jaky 47 captured it with an oscilloscope, but I guess that much is obvious - sorry don't know :)

I think there are two code issues involved here: 1) in init.ino, only the 3 cylinder case recognises that IGN_MODE_SINGLE is 'sequential' and sets for 720 degrees of crank. The...

Juan, please can you test the branch for PR 743? then Josh can more easily decide to include or reject the PR. 744 (the PR for change of even fire...

that looks good to me, what I'd expect for #743 - 1 cylinder single channel output 4 stroke - a spark every 720 - looks correct (agree?) no change for...

I think we all agree that if we were starting from scratch, even might be set at 360. But we're not and there are existing installations that are 180 and...

redoing as two PRs - one an LTS 'fix' for the original logic error , the other a non LTS 'improvements' (noise filtering)

i think it was discussed on discord some time ago, the priming pulse puts fuel in the cylinders regardless of flood clear. Maybe the change should also not do priming...