Jonathon Herbert

Results 26 issues of Jonathon Herbert

## What does this change? Updates our migration docs based on feedback using a stooge (moi) to kick off a migratin. ## How should a reviewer test this change? Do...

## Short description The `UpdateMessage` type contains every possible field an incoming message can have. Because not every message will have every field, each field is an option type. This...

To Review

## What does this change? Originally intended to be included in #20 – this PR cleans up a few things, reducing some repetition, and adding a few comments. ## How...

## What does this change? Add a Hunspell matcher for dictionary-based matches. The code itself should be fairly straightforward – we depend on [HunspellJNA](https://github.com/dren-dk/HunspellJNA) and [JNA](https://github.com/java-native-access/jna), which as far as...

re: inconsistencies in code style mentioned in #170

## What does this change? We've a few issues at the moment detailing errors that are the result of running Typerighter in a non-Guardian context. This PR updates our readme...

At the moment, we store the requestId for typerighter match requests in the body of the JSON we send. The method we use elsewhere is an X-GU-LoggingContext header. See https://github.com/guardian/flexible-content/blob/master/flexible-content-common/src/main/scala/com/gu/flexiblecontent/util/LoggingContext.scala...

## What does this change? Pins our semantic-release related GHAs, which are third party actions, to a particular commit hash, in line with the security advice for [third party actions.](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions)...

The difference between ignoredMarks and skippedMarks, callbacks provided in the public API, isn't clear: - ignoredMarks is a function that, given a node, returns ranges that invalidate suggestions returned from...

naming