Jonathon Herbert

Results 11 comments of Jonathon Herbert

This matches my understanding, also – we've just been caught by this when debugging a piece of functionality w/ prosemirror-devtools. (Lovely tool, btw. So useful for us at https://github.com/guardian, esp....

Does disabling Revolver explicitly on each project that does not require it help? (https://github.com/spray/sbt-revolver/issues/66)

@kenoir @jfsoul – looks like this is now working. No change on our side, so looks like Snyk has solved. Thanks for raising the PR! Should we close this, or...

Thanks for this! Quick double check – _> AR uses Thrift to deserialise the data into TypeScript format._ should I think be _> AR uses [@guardian/content-api-models](https://www.npmjs.com/package/@guardian/content-api-models) to deserialise Thrift into...

Thanks for the comments, all. @fredex42 yes, the third thing breaks this! @emdash-ie, that's a nice way of solving for that, and thanks for going to the trouble of writing...

> It might be worth adding some notes to the doc about the logic for the differences between `com.gu.facia.client.models.Trail` (from the path I assume it's a Thrift model) and `model.editions.EditionsClientCard`...

This would be a great improvement. Spoken AOB, but to summarise, for a public API the surface area here allows a few footguns: - no guarantee the node accepts text...

Thanks for the feedback, @rhystmills – fixed in [ed7a4d5](https://github.com/guardian/prosemirror-typerighter/pull/264/commits/ed7a4d560d32b107f6b151d69db5b707403a375c).

Thanks for the review! It'll go out with the telemetry, if that makes sense – the path is `event` and I think local is configured by default to point to...

Thanks for testing thoroughly! I'll revisit this PR soon.