Jonathan Strong

Results 29 comments of Jonathan Strong

this code has not been integrated into the crate or published to crates.io but might be of use if you need a solution quickly: https://github.com/jonathanstrong/decimal-macros. if you're interested in this...

I have code to convert `d128` to `u64` (and I think `u128`) somewhere. would that solve your problem?

hey - just looking at this. thank you for submitting the pull request. I did have one question, I'm not familiar with what `trim`/`decNumberTrim` does. I realize you switched to...

potentially? the C code has a comment describing `decNumberTrim` as "remove insignificant zeros", while the comment for `decNumberReduce` is "remove trailing zeros". I don't understand how these are different in...

hey @aidanhs, thanks for submitting a pull request. I realize it has been quite some time since you submitted this, and you are only now getting a response. I was...

this is explained in the documentation: > The syntax of the string is fully checked; if it is not valid, the result will be a quiet NaN and an error...

you're interested in the code that fixes the `uninitialized` usage, correct? happy to setup a clean pull request with those changes if so.

Are you sure? There are quite a few unrelated differences, including a `d64` type, some `From` and `TryFrom` conversion routines that should probably be reviewed, some dependencies brought in for...

ok, I pushed a branch to upstream (i.e. this repo) as I am now a collaborator (thank you). it is only the `MaybeUninit` conversion changes: https://github.com/alkis/decimal/compare/uninit-fix. next week I can...

I've ended up spending a lot of time on it, and it's a huge pain in the ass. I'm not any closer to a performant function to convert back and...