Jonathan Pallant

I'll take a look at this on Friday, hopefully

> The only missing feature which requires a fork: [embassy-rs/embassy#4700](https://github.com/embassy-rs/embassy/pull/4700) Is this now in embassy-nrf-v0.8.0?

Can you re-do this PR so that instead of a new crate called `dk-migration`, we replace the existing `dk` crate with an embassy based one? That would make it easier...

> Should we keep the dongle FW port as a separate PR? yes, the dongle uses a different BSP and so it can move to embassy-nrf on its own schedule.

I tested all the solutions on hardware and they look good. I have some patches to clean up the USB exercise, which I will do separately.

See https://github.com/rust-embedded-community/embedded-sdmmc-rs/pull/157

This looks great - just a clippy lint to fix about not waiting on a spawned process. That seems like it might be important.

Thank you for your proposed changes. I had a quick look and they seem OK to me, but I've asked my colleagues for a second opinion.

A couple more observations on a second pass, but I checked the diff in detail with a better diff tool, and most of the 'changed' code is unchanged - it's...

I tried to make use of this in defmt-print, so it could print JSON containing an array of fragments rather than a single string, but ran into issues in how...