Jonathan Pallant
Jonathan Pallant
This looks good to me and I'm inclined to merge, but I'd like to do some code size and compile time comparisons first.
I've pinged the team internally so we can work out how to fix those tests. We're on version 4 of the wire format already, so we must have a process...
We should probably fix the *input section* name at the same time (i.e. the `link_section = "...."`). Currently this is JSON, unless you are on macOS when we hex encode...
@Dirbaio did you have any thoughts on whether there's a more readable encoding than plain hex encoding here?
I gave it some thought. What about [`mangling::mangle`](https://docs.rs/mangling/latest/mangling/fn.mangle.html) main.rs: ```rust use std::io::Read; fn main() { let mut stdin = std::io::stdin(); let mut buffer = Vec::new(); stdin.read_to_end(&mut buffer).expect("reading stdin"); let result...
Yes, good point, we'll need to Mangle All The Things. > pipe their symbol names through a demangler will also see fully demangled defmt data I'm mentally uprating my idea...
The title says 0.3.13 but the defmt crate version has been bumped to 0.5.0 which will cause widespread breakage. Please can you clarify what version we're intending to release here.
I looked into this for you. The serialiser needs to report what kind of *thing* is being serialised so the deserialiser can unpack it. This is done using an interned...
Ah. ```rust pub fn fmt_slice(values: &[T]) { if let Some((first, remainder)) = values.split_first() { usize(&values.len()); istr(&first.format_tag()); first._format_data(); for value in remainder { value._format_data(); } } else { usize(0); } }...
We discussed this on the Matrix chat. If you'd like to propose a PR, we can look at exactly how breaking a change it is. The trick is handling the...