Jonathan Chen

Results 76 comments of Jonathan Chen

@mapleFU Test cases are implemented! Ty for the test suggestions.

@mapleFU Does this seem fine to move forward?

@mapleFU Alright, thanks for the reviews, I put the changes in for it.

@mapleFU Srorry about that, fixed the lint.

@mapleFU Were you gonna make your own changes to the code?

@PragmaTwice @Beihao-Zhou @LindaSummer Feel free to leave changes!

Took out column temporarily as it was failing tests. Will put it back in the full implementation.

@Beihao-Zhou I could, but I assumed that creating the time_encoding in storage is fine as it needs its own search and querying capabilities over subkeys unlike the stream data.

Yeah this was much needed thanks for bringing this up @UBarney

@xushiyan What are the differences between setting up on vscode vs. the set up already specified in contributing.md