kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

Published 20 hours ago • verified publisher icon apache

feat: support count min sketch data structure and most commands

Open jonathanc-n opened this issue 1 year ago • 21 comments
trafficstars

references issue: #2425

The commands, IncrBy, Info, InitByDim, InitByProb, and Query have been made.

The merge command will still need working on, and go integration tests will be added for the future. I will also probably add a cache similar to the hyperloglog for in-memory operations.

jonathanc-n avatar Sep 07 '24 02:09 jonathanc-n

Was there a change made to GetOptions recently? There seems to be a problem after the merge.

jonathanc-n avatar Sep 07 '24 03:09 jonathanc-n

Was there a change made to GetOptions recently? There seems to be a problem after the merge.

Yes, the operations to db requires an options here.

mapleFU avatar Sep 07 '24 04:09 mapleFU

I believe this pr should be good for further review

jonathanc-n avatar Sep 08 '24 23:09 jonathanc-n

Nice, I'll take a round tonight

mapleFU avatar Sep 09 '24 06:09 mapleFU

@mapleFU do the changes seem right? sorry for the bother.

jonathanc-n avatar Sep 10 '24 00:09 jonathanc-n

@PragmaTwice Is the workflow able to run again?

jonathanc-n avatar Sep 12 '24 01:09 jonathanc-n

do the changes seem right? sorry for the bother.

Sorry for delaying, I'll take a pass

mapleFU avatar Sep 12 '24 07:09 mapleFU

@jonathanc-n would you mind fix the lint?

mapleFU avatar Sep 13 '24 23:09 mapleFU

I'm outing these days, so maybe late reply

mapleFU avatar Sep 13 '24 23:09 mapleFU

@git-hulk @PragmaTwice I think a workflow can be run again with the changes

jonathanc-n avatar Sep 14 '24 00:09 jonathanc-n

@PragmaTwice Would you be able to review this pr?

jonathanc-n avatar Sep 17 '24 16:09 jonathanc-n

@mapleFU something seems to be a little odd here, I ran clang-format on all changed files and its running into formatting issues

jonathanc-n avatar Sep 21 '24 05:09 jonathanc-n

@mapleFU Test cases are implemented! Ty for the test suggestions.

jonathanc-n avatar Sep 23 '24 03:09 jonathanc-n

@mapleFU Does this seem fine to move forward?

jonathanc-n avatar Sep 26 '24 05:09 jonathanc-n

@mapleFU Alright, thanks for the reviews, I put the changes in for it.

jonathanc-n avatar Sep 29 '24 04:09 jonathanc-n

@mapleFU Srorry about that, fixed the lint.

jonathanc-n avatar Sep 29 '24 05:09 jonathanc-n

No problem, we're almost their

mapleFU avatar Sep 29 '24 05:09 mapleFU

I'm a bit tired today and will revisit this tomorrow

mapleFU avatar Sep 29 '24 17:09 mapleFU

I just reach home and have some minor updates, would continue tomorrow. Sorry for delaying

mapleFU avatar Sep 30 '24 15:09 mapleFU

@mapleFU Were you gonna make your own changes to the code?

jonathanc-n avatar Oct 01 '24 23:10 jonathanc-n

Yes I'm back from holiday and working, would continue.

mapleFU avatar Oct 11 '24 03:10 mapleFU