Jonathan Kingston

Results 187 comments of Jonathan Kingston

Hey @fangshih we have just reverted back to the code that is in Nightly at the moment and didn't get time to update these. I think that we might get...

Existing Containers profile, then updated to 2.3.0. Unbranded 53.0.2 > about:support Application Update Service Helper 2.0 true [email protected] Containers Experiment 2.3.0 true @testpilot-containers Multi-process staged rollout 1.14 true [email protected] Pocket...

Debugging - index.js `async getTabs(args) {` - Which then calls: `sendReply(this[message.method](message));` - returns a promise which I was expecting to be resolved here: - http://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionChild.jsm#352 Unanswered questions: - Is there...

IRC paraphrase for anyone else interested about the "fix": This fixes the panel opening issue, it creates the likelihood that some icons might turn into pages even for nightly. In...

Tested on latest release unbranded 53 on a fresh profile and the issue doesn't happen.

@kjozwiak's comment from the previous bug... > @kjozwiak would really appreciate your eyes on this as I dunno what is causing this and it might mean we have to cut...

The follow up to this bug should be using web extensions which likely wouldn't be impacted by this issue at all here. Pushing a bigger SDK removal patch to prod...

Mozregression pointed at: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b01f44c896b2472b154a48c68cf343ae2289d6bd&tochange=d80c517658f5048491b7bf27da25246a297ab50b being the fix for this. So it will likely not impact newer builds that this.

@groovecoder can you not combine: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webNavigation/onCreatedNavigationTarget with a blocking onBeforeRequest? I will try and make a sample tomorrow, looks like 54 supports this and it should be better for assignment...

I wonder if on tab created that is default should just open in the current container if there is one would be good enough here. And perhaps the navigation target...