Jonathan Kingston

Results 187 comments of Jonathan Kingston

@princiya it might make sense to create a branch here and use the dynamic data we have here?

@princiya to make a branch of the lightbeam code with web vr enabled using the storage code rather than a dump of the data.

@caseyyee I would rather not dump mine, however it's super easy to get. Install Lightbeam from AMO then click the save button after browsing a few news sites. :) I...

` if (newThirdParty) {` within `setThirdParty` needs to check if both firstParty and thirdParty already existed if they don't then this shouldn't fire. Basically this line should only pass when...

Ugh calculating the O notation is painful, anyways... it's not going to exponentially grow with the size of the graph. This should make this a p2 at least.

Also I probably wasn't clear but there will be more updates than there are new nodes added to the graph. Fixing that line should make it send update on new...

For now don't look for third party favicons. Getting on a plane now... Might be late to our meeting. see the note. Thanks On Mon, 26 Jun 2017, 17:12 Bianca...

@princiya the code https://github.com/electrolyfish/lightbeam-we/blob/master/js/store.js#L62 needs to be moved into non functional code, even if we make it require a console call to trigger it for now. However moving this to...

I don't really know what that is, can't you use a MINGW based setup like git bash instead? Is the build script the only thing that is broken?

I use Windows as my default (granted this is a recent change), I wouldn't ever touch cmd where possible. I'm worried this small change will lead to us maintaining a...