Jonathan Lee

[wptmanifest] Improve parser/serializer comment support

1

This change enables the metadata parser/serializer to preserve comments documenting test expectations. Currently, the parser ignores comments, which are lost when updating metadata from logs. * The tokenizer now allows...

[wptrunner] Add `infrastructure/expected-fail/` test for user prompts

1

This test exercises the handling of a testharness.js test that opens user prompts like `window.alert(...)`. For WebDriver-controlled browsers that default to "dismiss and notify", this should raise a harness error...

[wptrunner] Only load relevant tests

9

Currently, wptrunner selects tests by loading all tests for enabled types via `Manifest.itertypes(...)`, then applying path exclusion/chunking. This is wasteful when only a few tests will run, and is especially...

[wptrunner] Add `testloader.TestFilter(...)` tests

1

Capture the current test include/exclude behavior to provide confidence that refactoring/optimizations (#42377) don't regress functionality.

WebDriver executor ends each `testdriver` action with the `testharness.js` window selected

1

See #44688 for full background. The WebDriver implementation of `testharness.js` must switch to the `testharness.js` browsing context to run [`testharness_webdriver_resume.js`](https://github.com/web-platform-tests/wpt/blob/master/tools/wptrunner/wptrunner/executors/testharness_webdriver_resume.js). In a tabbed browser with popups in the same OS...

https://github.com/web-platform-tests/rfcs/pull/22 removed this requirement, and it's no longer documented as an assumption (https://github.com/web-platform-tests/wpt/pull/18972).

The test drops testdriver commands and [times out in all browsers][0] because: 1. The top document doesn't [embed `testharness*.js`][1]. 2. The opened document needs to [`set_test_context()`][2] to send testdriver commands...

[manifest] Combine reference and variant query string parameters

1

Both the reference URL and variant value may specify separate sets of parameters. It makes more sense to merge these parameters than to concatenate the raw values, which [can generate...

WIP implementation for #13183 (will also need RFC)

[wptrunner] Add type hints for `wptrunner.browsers.chrome`

1

... in lieu of the Chrome `infrastructure/` coverage the upstream CI doesn't have. Hopefully this will reduce the time wasted fixing trivial breakages only discovered downstream. Chrome Android type hints...