jojo

Results 22 comments of jojo

I usually prefer one and only one way of doing things, if possible, since it leads to less confusion. In the currency scenario, we already have two ways of picking...

I proposed this because I think that the way it works today has some drawbacks: - Custom flag to enable TLS. We could strive to have the same behaviour as...

Here's an example on how this works: https://gist.github.com/jonatasbaldin/17379c34d5cc20815933edaeb42311fa

It did work, I just removed after my testing heh By default there are no annotations, it depends on the ExternalDNS configuration. It could manage DNS for Ingresses, Services etc....

hey @ahmedwaleedmalik, thanks for moving on with the PR :) I was wondering about the E2E tests, which require a Vultr API Token. How does that work? Who generates and/or...

Fixed the lint issued. As you can see on the failing licenses tests, the Vultr GO SDK depends on two projects by Hashicorp with MPL2 licenses. Is is ok to...

Hi there. We unfortunately can't provide a Vultr token for the E2E tests. We will get in touch with the Vultr team in search for a collaboration. I'll let you...

What about adding the `cert-manager` and `nginx-ingress` templates into the Helm one as dependencies, enabled/disabled through a flag? It could be at least a nice way to prototype the deployment...

I agree with you @lamw. We could accomplish this by adding an entry to `~/.openfaas/config.yaml`: ``` yaml auths: - gateway: http://127.0.0.1:31112 auth: basic token: tls_no_verify: true ``` And check this...

If these is an accepted design, I could work on it.