Jonas Nick
Jonas Nick
Marked as draft since there's still work to be done (BIP number) but it's ready to review.
Also, this PR is staying a draft until https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-October/021000.html is addressed.
> Also, this PR is staying a draft until https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-October/021000.html is addressed. I pushed a version of the BIP draft that addresses this and therefore this PR is ready for...
It's possible and used in the library tests to exhaustively run checks on all elements of a small subgroup. See https://github.com/bitcoin-core/secp256k1/blob/master/src/tests_exhaustive.c and https://github.com/bitcoin-core/secp256k1/blob/2f984ffc45eba89faa9e79da3d5d5bd50a6c1c3d/src/group_impl.h#L34. By the way, as far as I...
@sipa > We could drop the optimization, but unless there is a concern that having code for optimization present would be misinterpreted as "supported", we could also just leave it...
I'd be in favor of calling the non-deprecated flag NONE and keep it being the neutral element wrt `|` as you're suggesting. When I wrote the code you reference I...
I should also move `doc/CHANGELOG.md` to `CHANGELOG.md`.
I rebased the PR. After it is merged, the next step would be to create a release branch and tag the release. But after rereading the release process, I see...
After talking with @real-or-random I addressed above issues by 1) changing the patch version to 99 on master and 2) removing the dummy date, which required setting an actual release...
Ok, I've made a couple of releases in my fork and updated the release process to include more git commands to avoid mistakes like forgetting to pull. I've also clarified...