Jonas Finnemann Jensen

Results 459 comments of Jonas Finnemann Jensen

Allowing the comment before will probably backfire in cases like: ```yaml - 1 - 2 # line1 # line2 # line3 - 3 ```

This could work: ```yaml - 1 - > new text with 2 space indentation # comment with one space indentation - 3 ``` but it also fail if the comment...

yeah, we probably just should remove the comment in all such cases.

@kekavc24 I'm not sure this is a new bug caused by https://github.com/dart-lang/yaml_edit/pull/87 but it's something we should fix. At a minimum we should fallback to double quoted string encoded, if...

Btw, I can be found on [dart_community](https://discord.gg/Qt6DgfAWWx) discord, I'm jonasfj, feel free to ping me.

> Sorry for this. It seems I overwrote it as I was resolving some merge conflicts I encountered while rebasing. Yeah, the PR was getting pretty complicated, we should probably...

Okay, this might take a while to review. Thinking about it, I do wonder, is it really a good idea to use folded or literal strings without chomping `-`? Certainly...

Sure, no problem.

Honestly, anyone is welcome to help write a few test cases. Especially, if we can make some test cases that finds new bugs, then we can file issues to fix...

In particular, we need test cases for strings that contain special characters, line breaks and the lines. I think we have issues when such strings are formatted as folded strings,...