Jonah Williams

Results 585 comments of Jonah Williams

I think most of these changes should be made to the existing raster strategy, and we don't need to necessarily introduce a new render object. Also, most of the new...

``` [2024-06-14 22:01:27.316866] [STDOUT] stdout: [+1148 ms] 00:00 +0: scrolling performance test (setUpAll) [2024-06-14 22:01:27.327634] [STDOUT] stderr: [ +10 ms] VMServiceFlutterDriver: Connecting to Flutter application at http://127.0.0.1:44023/wdqrf-5-jA4=/ [2024-06-14 22:01:27.419359] [STDOUT]...

Seems like the platform views test is failing to produce images at a certain point? Or perhaps never produces an image. We should run this locally to confirm and/or verify...

This might be "fixed" (the crash, not the state error in the image reader code) because I've changed image acquire to handle an invalid image on the native side.

These errors look similar to https://github.com/flutter/flutter/issues/150492

Closing as fixed, https://github.com/flutter/engine/pull/56105

@fzyzcjy why do you think this isn't a duplicate of #8230. These are both feature requests for platform specific assets?

That's a good point. I had considered excluding assets as part of that feature request inherently, but it isn't very explicit in the original bug.

The matrix is currently incorrect. Since it will be hard/difficult to do a picker of extendedSRGB we'd need to get the display p3 ctor working.