Jonah Tan
Jonah Tan
> For both the PR preview of the previous fixing PR(https://github.com/MarkBind/markbind/pull/1837) [here](https://deploy-preview-1837--markbind-master.netlify.app/userguide/formattingcontents) and the master branch docs [here](https://markbind-master.netlify.app/userguide/formattingcontents), the weird duplicate scrolling issue in https://github.com/MarkBind/markbind/issues/1794 doesn't show up when I...
Nice work @kaixin-hc 👍 Just some initial thoughts. > Is the site.json file copied over in the versioned files still being used? Can the user edit the archived site? From...
> Wonder if we should have a root level attribute "archivePath" to keep track of the output instead of duplicating it in individual "output" (assuming that all versions will share...
Thanks for investigating this @kimberlyohq 👍 > Error in getting remote branch file: > ``` > GitError: fatal: Not a valid object name origin/master:CNAME > ``` Noticed another potential issue...
Hmm seems like this is an issue with git's `cat-file` command itself. The command doesn't seem to be able to 'cat' a file from a remote repo using the url....
Here are some of my thoughts on this. > Would we want to allow editing the past versions? I think it would be nice to support editing past versions as...
Thanks @tlylt for investigating this issue. > After tracing the code for a bit, I realized that this is actually an added feature of markdown-it's [linkify-it](https://github.com/markdown-it/linkify-it). This is enabled in...
Seems like it is possible to set some rules on linkify through markdown-it.  What do you think of disabling fuzzy link so that only text with explicit `http(s)://...` is...
Wonder if there is an easier way such as removing the existing rules and define our own validate function? Seems possible with [this](https://github.com/markdown-it/linkify-it#addkey-value) but I have not tried it out....
> There's a bit of logic in markdown-it to handle linkify [here](https://github.com/markdown-it/markdown-it/blob/master/lib/rules_core/linkify.js). Linkify itself only does the link-text finding and hence if we remove the existing rules provided by markdown-it,...