Jon Betts

Results 15 comments of Jon Betts

I'm reverting this for the moment: https://github.com/hypothesis/h/pull/6106 I think this commit is dangerous in it's present state as users on pages without a "canonical" link, but with a "authuser" will...

## This is probably not straight forward at all There are a couple of different interacting pieces at play here: * We have the URL normalisation logic at the bottom...

@klemay I think this has been deprioritised for now, so I'm going to sling it out of the sprint. The last I think I know about this is that Jon...

Oh noes... I've also fixed this in a different way in: https://github.com/hypothesis/h/pull/5819

@lyzadanger Well I suppose it's mostly a learning exercise. The fact I ended up with a fix in the same place in the code is a good thing! I want...

Just had a quick chat with @lyzadanger about her ideas on the ticket. A quick summary: * The error looked like it might be a validation layer problem (webargs, marshmallow...

Yeah, no such luck. The error "Changing group type is currently not supported" is raised directly by "deform" based on a Colander schema. So I'm none the wiser.

As far as I can tell this has always been this way. This appears to have been added by us on purpose in: https://github.com/hypothesis/h/commit/cad0f8e3e91bf072143ff11c2f519b6b5b5d3dbc Discussions relating to why are here:...

There's nothing I can spot in the code to support that, so maybe there was some friendly DB admin style help? In any case, it doesn't change the fact it...

It's possible to do this, but it's not possible to do it well and quickly for a few reasons: * Our current "presenter" service is really setup to serialise multiple...