John Olheiser

Results 50 comments of John Olheiser

Yeah....this is tricky because it seems that some of this only applies to customized rendering. Under semver sorting the first item in the slice would be latest, but I'm not...

@zeripath Thanks for the patch! I've applied it, so now this is using the latest version of `chroma`. CC @yuin

> This PR breaks goldmark-highlighting compatibility as well. So This should be v2. Fine with me. Do you want me to mark this `go.mod` as `v2`? Do you want to...

Instead of post-install hooks, what about post-install instructions?

`embedded` is the correct sub-command name. The reason strings that aren't valid sub-commands boot up gitea is because of https://github.com/go-gitea/gitea/blob/838fef2ae84f8752363e8e3e31c252d66a5c6027/main.go#L98-L101 We are setting the default command to be the same...

> How much is the binary size effected? On my machine it looks like it increased ~2mb EDIT: When I built the "old" version I forgot to use the `sqlite`...

I'll have to take a look at why we need to set those values/where they are being used. Unfortunately Go itself doesn't really allow setting context values without the whole...

-1 for the go `plugin` package. It can't be removed per compatibility promise, but it is absolutely not stable, and there are far too many caveats to get it working...

I would also like to throw [yaegi](https://github.com/traefik/yaegi) into the mix. I think gRPC is probably the only way to go (unfortunately), but figured yaegi is worth considering as well.

> We could probably get some ideas on how mattermost have implemented their plugin system. For posterity: [mattermost plugin package](https://github.com/mattermost/mattermost-server/tree/master/plugin) It looks like they use [go-plugin](https://github.com/mattermost/mattermost-server/blob/5544e753e89d990ee87d63eae8082beb65ba0778/go.mod#L31)