John Wesley

Results 10 comments of John Wesley

Had a similar issue. Look for and remove any Helm related secrets.

@Himangini Could someone review this for me? I made the updates and and all tests ran cleanly, and I was able to build successfully.

I've cleaned up the conflicts, but `make check-all-generated-files-up-to-date` wants to revert back to version 1 (see below), so I have missed some updates. I will have another pass. ```shell diff...

Still receiving the same errors from `make test` @Himangini . I've updated `eksctl/pkg/eks/mocks/mocks.go` with the updated imports. I'm not familiar with mockery and will need to dig into it a...

There's also `eksctl/pkg/eks/api.go` vs `eksctl/pkg/eks/apiv2.go`. Is `api.go` scheduled for deprecation?

Any word on deprecating `eksctl/pkg/eks/api.go` @Himangini?

Hi @TiberiuGC. I would like to contribute 😄 but I wonder if the scope of this task is beyond one PR? If the change is to remove aws-sdk-v1 dependencies, then...

Is this a `good first issue` candidate?

@Skarlso would you please label https://github.com/weaveworks/eksctl/pull/5400 a WIP?

@TiberiuGC I agree. Can we narrow the scope of this PR to a single pkg?