John Jackson
John Jackson
Thanks for the contribution! I don't think I have any objections to this kind of feature, at least not from glancing at it so far. Right now, I'd be fine...
Can you run `npm run test -- --updateSnapshot` and commit the changes? I think that should fix the failing test.
The changes look good to me so far. One question though is how, or if, we want these new match results to affect the pairing and tiebreaking rules. For example,...
One more thing: please add a short entry to the changelog file. (You can just put it under the "latest" heading.) Aside from that, I think it looks good!
Everything looks good to me. We can always tweak things later if it turns out we need to.
Even if it isn't possible to transform strings via PPX, another possibility would be to include the entities as values like `` let nbsp = `\xa0` ``, which could be...
That seems like a reasonable compromise. IMO the fact that there is no documentation on the topic, combined with people being used to HTML entities "just working" in Babel JSX,...
For anyone interested in copying entities into their own project, I just pushed a commit with an `HtmlEntity` module here: https://github.com/johnridesabike/coronate/blob/e42688a04f34eccf0003b428e0f13054dd80a9b2/src/HtmlEntities.res
Yes! It was very easy to adapt from the Babel file, so feel free to link, copy, or do whatever with it.
That would be cool if it was possible, although that would have to still desugar/compile to function calls, right? Js.Dict can potentially compile to an object literal, which seems much...