NavigationBackport icon indicating copy to clipboard operation
NavigationBackport copied to clipboard

Introduce NBNavigationSplitView as a backport of NavigationSplitView

Open strangeliu opened this issue 2 years ago • 1 comments

Apple introduced NavigationSplitView in WWDC22, this is a backport implementation of it with limitation:

  • only support double colunm layout (sidebar + detail)
  • can not nested in NBNavigationStack

Pease see the demo for usage

strangeliu avatar Jul 16 '22 05:07 strangeliu

Thanks @strangeliu for the PR. I haven't yet had a chance to look at it in detail but I will try to soon.

johnpatrickmorgan avatar Jul 18 '22 23:07 johnpatrickmorgan

when this will be merge ?

X901 avatar Nov 03 '22 11:11 X901

Any updates here? Looking forward to have NBNavigationSplitView

distivi avatar Dec 12 '22 12:12 distivi

Sorry for the radio silence on this issue. I've been working on a slightly different implementation that would overcome the drawbacks that @strangeliu mentioned (thanks for your work on this @strangeliu!). I'm just working through some remaining issues before sharing it. Thanks for your patience.

johnpatrickmorgan avatar Dec 14 '22 09:12 johnpatrickmorgan

I've raised a PR #28, attempting to overcome the limitations @strangeliu described here. The API more closely resembles that of NavigationSplitView, in that you can have two or three pane layouts, and you can nest a NBNavigationStack inside a NBNavigationSplitView, though it must be within the detail pane only. Thanks @strangeliu for instigating this. If anyone feels like checking out that branch and trying it out, any feedback would be gratefully received. 🙏

johnpatrickmorgan avatar Dec 17 '22 23:12 johnpatrickmorgan