John Zhou
John Zhou
Thank you @FranzBusch for your timely response!
Hi @Lukasa, >While we're here, it's worth calling out that this is an incomplete solution, as there may be ChannelHandlers that have also buffered some bytes. This is a very...
Sure. Actually I'm working on the tests - should be ready soon. Thanks for the reminder!
Hi @Lukasa, whenever you are available, could you take a look at the code change. Appreciate your time and help in advance!
Hi @Lukasa @weissi, thanks for the help refining my PR. I think it is ready now. Whenever you have a moment, could you please review the change? Your feedback is...
Thanks @Lukasa for the review! I synced the PR with the main. It requires maintainer approval to kick off the pipeline. If you are available, can you help rerun the...
Hi @Lukasa, Thank you for consistently monitoring this PR. I noticed that the latest pipeline failed on the formatting check again - my apologies. I’ve updated the PR based on...
> I am a bit unsure if the word `audit` is the right one here. Could we just drop that from all the APIs here? What do others think? Hi...
> Do we need count even here? What about `NIOOutboundByteBufferingChannelHandler`? The current name of the property sounds good to me. I'm generally ok with `NIOOutboundByteBufferingChannelHandler`. However, my main concern is...
Sounds good. I will make the change accordingly. I will add more test cases in other commits.