John M. Horan
John M. Horan
For easy reference the RTD update is here (although the new TOC doesn't show up in this simple .rst file). https://github.com/nexB/purldb/blob/f49eff87ae9a4226584096498836de7d5015f6a2/purldb-toolkit/README.rst
@pombredanne Now that I'm removing all logging/messaging, how do you want to handle a command run on a PURL whose type is not supported? Supported types are different for each...
@pombredanne Given our recent discussions as well as the [feedback](https://github.com/nexB/fetchcode/pull/119#pullrequestreview-2102494631) you just provided re the fetchcode cocoapods work (thank you!), I think the answer to my question is: let the...
Thanks @pombredanne . Adding a new exception is an interesting option. For testing, in purlcli.py, I've added ``` class UnsupportedPackageType(Exception): pass ``` and for the `metadata` command, inside [collect_metadata()](https://github.com/nexB/purldb/blob/6b6a8381abff5f8f882daf8f479fb87f2a66e1ca/purldb-toolkit/src/purldb_toolkit/purlcli.py#L115-L127), I've...
@pombredanne I'm cleaning up `purlcli.py`, and then the 2 test files, and will commit and push when done. I realize you've had no time to read and reply to [my...
@pombredanne I did not follow all that you wrote but for now I am not making any more changes along these lines until we can discuss and I can ask...
@pombredanne I've finished removing the PURL CLI logging/messaging structure I'd added, merged the most recent `main` as well as your latest commit to this PR, resolved conflicts, and otherwise updated/fixed...
I've just committed and pushed my remaining updates for the metadata command in purlcli.py. Waiting for the GH checks to run.
@pombredanne @keshav-space @TG1999 All GitHub checks have passed. This PR is ready for review at your convenience. Please note that the purlcli code relies in part on updates I've recently...
See also my [2024-03-05 fetchcode issue](https://github.com/nexB/fetchcode/issues/109) discussing several examples of exceptions that interrupt the flow of the relevant PURLCLI command and my approach -- logging, reporting in the output `errors`...