John M. Horan

Results 146 comments of John M. Horan

Rather than post the verbose output here I pasted to a .txt I'll upload.... [packageurl-python-purl2url-pypi-sample-output-2024-03-11.txt](https://github.com/package-url/packageurl-python/files/14566168/packageurl-python-purl2url-pypi-sample-output-2024-03-11.txt)

@TG1999 Further to your (and other) comments in the recently-closed prior [PR 151](https://github.com/package-url/packageurl-python/pull/151), I've removed most of my prior code, and this issue -- and the new PR I'll open...

@TG1999 Actually, I'd forgotten that [fetchcode/package.py](https://github.com/nexB/fetchcode/blob/master/src/fetchcode/package.py#L170-L208) already handles pypi, including providing a single download URL entry (just one, as is the case for the other supported types as well, although...

@TG1999 Thank you for your comments. I've just pushed my responsive updates. - I added `"pkg:cocoapods/": None,` to `test_purl2url_get_repo_url()` and added `"pkg:cocoapods/": [],` to `test_purl2url_get_inferred_urls()` as you requested to test...

@TG1999 You asked me to remove the two print statements I added to `purl2url.py`, one in `get_download_url` and the other in `build_cocoapods_repo_url`. Is this what we want for the cocoapods...

@pombredanne @TG1999 I've just committed and pushed my changes in response to @pombredanne's recent comments. Please take a look when you can.

@pombredanne I've restored the support/download URL comments we discussed.

@pombredanne Just confirming that this PR is ready for your re-review when you have the time.

@majurg Will our new `status`, `has_license` and `has_copyright` attributes and related methods entirely replace the existing methods/scoring for license and copyright changes (i.e., no more use of `license info added`...

Excellent. Thanks, @majurg . I'll include it in my current work rather than opening a new ticket. (I'm tackling issues #107, #109 and #110 together under the 107 rubric.) If...