John Mayfield

Results 241 comments of John Mayfield

Oh it was almost certainly an unexpected change we should revert..

As a rule of thumb though... these hashes are meant to be fleeting and tied to a specific version of CDK. Otherwise you get into an InChI situation where they...

Was this the change, https://github.com/cdk/cdk/commit/5b5fcd3d5d08d27eec60f1ebef699cf35c3247c2#diff-05553058975e75eb43cf0b94414f29f44510630a0a647610876b5446c4b55a93. You can see it was part of a large change set from a SonarCloud alert. Please update to keep the old behaviour if you need...

Yeah I see it, for some reason a downstream test broke: https://pubchem.ncbi.nlm.nih.gov/compound/44333798 https://pubchem.ncbi.nlm.nih.gov/compound/57170558 Initially without a stronger tie-break these (should) generated the same HASH. But with that int -> long...

> I don't think the change of seed from int to long had any impact here on the actual outcome as It does change the hash, but yes the masking...

Yep, need to play around a little,

The overheads: - JENA ~20MB - CMLXOM ~6MB (log4j-core is a big contributor) - JNA InChI ~6MB - xerces+xalan ~4MB (used in multiple places) - cdk-builder 2.2MB (mainly a zipped...

w.r.t to iordf I wonder if we just write our own owl reader/writer. I presume the specs of these are super extensive though so might be an impossible task. Otherwise...

Set packaging type of cdk-bundle to “war” instead of “pom” then add an empty web.xml file in the correct place (it tells you where). But I’ve given the sizes there,...

Although I think as rajarshi pointed out, it basically is just all functionality made available so really “everything” is needed but choices can be made to cut the less essential...