John Kessenich

The key missing functionality here is glslang implementing the ARB include extension, which could be done. Let's keep this issue about adding that functionality to glslang.

Since all but the last comment were written, I added "normal" include to glslang proper. This includes, from the usage statement: ``` -I add dir to the include search path;...

I don't see this in the code base.

OpenGL is a different execution environment that supports different features than the Vulkan execution environment. It is probably not too difficult to plumb HLSL -> glslang -> SPIR-V-for-OpenGL, if we...

glslang does not currently translate multiple stages at one time into a single SPIR-V module. I think the plan here is to use a linker/merger that can combine two SPIR-V...

Takes a while to figure out what's at issue here. I think the problem you have is that after googletest runs you see this: ``` [==========] 1382 tests from 54...

I looked at the code, based on the call stacks you provided: - the double free could only be happening at process exit, as these are not newed/deleted, they are...

Yes, but is it a bug with the intended use of glslang, or just a testing harness issue? It seems to pass the tests and not relate to core use...

I don't quite understand yet. Is this for OpenGL? I know Vulkan only has bindings for uniform buffers, and was thinking that's true of all SPIR-V, but perhaps not. Also,...

Here's the normative language from the specification: > The location identifier can be used with default-block uniform variables and ... Individual elements of a uniform array are assigned consecutive locations...