John Jenkins comments

Results 120 comments of


                                            John Jenkins

[🐛 Bug]: Cannot find mocha.css

another workaround is to just install `mocha` as devDep

bug: Event payload with self-reference causes type generation error

hey @Mitiryl, Can you give me some idea around what you were wanting to achieve here? ```tsx @Component({ tag: 'my-component', shadow: true, }) export class MyComponent { @Event() myEvent: EventEmitter;...

bug: Stencil build output contains comments and code is not minified

hi @BenyAmir 👋 I think these inconsistencies have just grown organically over-time as features were added. I do know that it was always intentional that code intended for downstream bundlers...

nuxt-security breaks `sourcemap: true`

Seems related to https://github.com/Baroshem/nuxt-security/pull/420 - setting `removeLoggers: false` fixes the issue

feat: Allow "slotAssignment: 'manual'"

@fgeierst - sorry, no updates and not much capacity atm. Any help much obliged!

bug: nested to ::slotted in scoped component

@AndreBarr - no, sorry. Any help gratefully received!

fix(runtime): ensure parentNode and parentElement consistency for slotted content

Hey @christian-bromann ! I feel like this could be a mistake? isn’t the idea that the scoped behaviour mirror shadow dom behaviour? Additionally, I think might cause issues with frameworks...

fix(runtime): ensure parentNode and parentElement consistency for slotted content

I believe the correct behaviour should be for parentElement to also return the component host

fix(runtime): ensure parentNode and parentElement consistency for slotted content

I’d think the fix needs to be on the insertBefore monkey patch we have on host element? That’s what it is designed to do. Want me to try?

fix(runtime): ensure parentNode and parentElement consistency for slotted content

@christian-bromann do you have a link to the 'real-world' example for me to look at? The attached angular issue seems to work correctly via adding `scoped: true` (which applies the...