John Jenkins

Results 120 comments of John Jenkins

> My use case for the patches is exactly what you said, I generate Angular component wrappers and I need the patches to avoid errors in Angular. And that's why...

No problem - it's not obvious stuff :) I'd say that component is - strictly speaking - implemented incorrectly. In reality though, there is no internal markup to 'protect' so...

hi @glushkova91 - can you please add a reproduction 🙏 It makes our lives so much easier to replicate the issue, see if we can tweak the repro to work...

ty! Interestingly if you add the `shadowrootdelegatesfocus` ala `` it **almost** passes: I think it should be relatively straightforward to fix

hey @janerikmai / @ReneWerner87 - thanks for being patient! I've just taken the repro for a spin with the latest Stencil (4.39.0) and the issue seems to be fixed https://codesandbox.io/p/github/johnjenkins/stencil-busted-getset-types/main?file=%2Fsrc%2Findex.html%3A18%2C27&workspaceId=ws_F7GcSjr2scsinqA3tNxabd...

hi @katteri-hpe - this was an intended change, because the auto-added package.json within `loader`: 1) was antiquated in it's assumptions (e.g. `es2015`, `es2017`, `typings` (instead of `types`), no `exports` etc)...

> @johnjenkins tried a different approach. Some checks didn't run in the PR, but I lack context. Hope someone can review this since I still have a lot to learn...

@danielleroux I'm pretty sure this is due to https://github.com/stenciljs/core/pull/6331 < do you have any insights? (@mamillastre I believe this stems from Stencil components now rendering much faster - perhaps Angular...

It does seem to be an issue; Ionic users have also reported it: https://github.com/ionic-team/ionic-framework/issues/30613