Ronny Pscheidl

Results 12 comments of Ronny Pscheidl

perhaps this could be helpful package.json: ```json { ... "scripts": { ... "postinstall": "electron-builder install-app-deps && rm -rf ./node_modules/ffi-napi/build", ... } ... } ```

are these lines really right: - https://github.com/Ylianst/MeshCentral/blob/9d21823e5fa94162cb235a2f673d3e363a42f1b8/db.js#L3261 - https://github.com/Ylianst/MeshCentral/blob/9d21823e5fa94162cb235a2f673d3e363a42f1b8/db.js#L3278 - https://github.com/Ylianst/MeshCentral/blob/9d21823e5fa94162cb235a2f673d3e363a42f1b8/db.js#L3241 this ``` for (var i in usergroup) { uusergroup[i] = usergroup[i]; } ``` is a map operation but it...

i think you have also to change this: https://github.com/Ylianst/MeshCentral/blob/master/db.js#L3298 to this: ``` var usergroup2 = Object.assign({}, usergroup); usergroup2.action = (added ? 'createusergroup' : 'usergroupchange'); usergroup2.ugrpid = usergroup2._id; usergroup2.nolog = 1;...

is it possible to make this part working? whether you delete e.g. a group, after a page reload you get all items from the cache, which isn't updated: https://github.com/Ylianst/MeshCentral/blob/master/db.js#L900

please fork and update yourself to keycloak version. i have no time to maintain anymore.

I have extended the testOrderIP test by the commonName with an IP. The result looked good in the debugger. DNS commonName: IP commonName:

> Thanks for these changes @johnjcool, LGTM! Could you update the PR description and release notes? I think "removed unnecessary check" no longer applies. done