John Hunter

Results 50 comments of John Hunter

@zachleat is there anyone who could review the PR even if they can't merge it? It might help move things along. Thanks.

@sapphi-red excellent points, answers below: > 1. Do you think there's a case where users want to skip setting the origin header? I can't think of a case for skipping...

> We can introduce a different option like `changeOrigin: 'both'` to be really safe. But I think we can try this out without that in the next minor beta version....

Thanks for the response and explanation @tryforceful. I think the best approach is to: - revert the `changeOrigin` behaviour to the original - add a new option `rewriteWsOrigin` that rewrites...

Issue and PR raised https://github.com/vitejs/vite/pull/17563

duplicate of https://github.com/arqex/react-datetime/issues/746

Should probably add eslint rule https://eslint.org/docs/rules/no-console

Seems the problem is that when the template is processed it is not aware that the link is defined in a common layout. Ideally it should process the asset based...

While discussion on removing changeOrigin continues, can we not update the docs to clarify what the setting actually does? It does not change the origin header but consuming projects assume...

I had the same warning when using `InputBase` to render the `input` prop of `Select`. Filtering it out of the props resolved the issue.